Skip to content

Small cleanup of our visibility modifiers #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Small cleanup of our visibility modifiers #876

wants to merge 2 commits into from
+15 −15

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Oct 8, 2025 •
edited
Loading

I'm opening this one for discussion. These changes do not impact the visibility of our types at the bindings layer, only at the Rust layer and as a signal to developers and contributors.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@thunderbiscuit
Copy link
Member Author

I'm happy with how little changes are in this; I was expecting to find more.

In cases where things were pub or pub(crate) and could be made private I did it, and in cases where we had methods set to pub(crate) when in fact they are meant for public consumption I made them public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
BDK-Bindings
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thunderbiscuit